lkml.org 
[lkml]   [2018]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v11 00/10] Application Data Integrity feature introduced by SPARC M7
Khalid Aziz <khalid.aziz@oracle.com> writes:

> V11 changes:
> This series is same as v10 and was simply rebased on 4.15 kernel. Can
> mm maintainers please review patches 2, 7, 8 and 9 which are arch
> independent, and include/linux/mm.h and mm/ksm.c changes in patch 10
> and ack these if everything looks good?

I am a bit puzzled how this differs from the pkey's that other
architectures are implementing to achieve a similar result.

I am a bit mystified why you don't store the tag in a vma
instead of inventing a new way to store data on page out.

Can you please use force_sig_fault to send these signals instead
of force_sig_info. Emperically I have found that it is very
error prone to generate siginfo's by hand, especially on code
paths where several different si_codes may apply. So it helps
to go through a helper function to ensure the fiddly bits are
all correct. AKA the unused bits all need to be set to zero before
struct siginfo is copied to userspace.

Eric

\
 
 \ /
  Last update: 2018-02-02 03:30    [W:0.075 / U:0.684 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site