lkml.org 
[lkml]   [2018]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] dt-bindings: Documentation for qcom,llcc
On Thu, Jan 25, 2018 at 03:55:12PM -0800, Channagoud Kadabi wrote:
> Documentation for last level cache controller device tree bindings,
> client bindings usage examples.
>
> Signed-off-by: Channagoud Kadabi <ckadabi@codeaurora.org>
> ---
> .../devicetree/bindings/arm/msm/qcom,llcc.txt | 93 ++++++++++++++++++++++
> 1 file changed, 93 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,llcc.txt
>
> +Example:
> +
> + qcom,system-cache@1300000 {
> + compatible = "qcom,llcc-core", "syscon", "simple-mfd";
> + reg = <0x1300000 0x50000>;
> + reg-names = "llcc_base";
> +
> + llcc: qcom,sdm845-llcc {
> + compatible = "qcom,sdm845-llcc";
> + #cache-cells = <1>;
> + max-slices = <32>;
> + };
> +
> + qcom,llcc-ecc {
> + compatible = "qcom,llcc-ecc";
> + };
> +
> + qcom,llcc-amon {
> + compatible = "qcom,llcc-amon";
> + qcom,fg-cnt = <0x7>;
> + };
> +
> + };

The "qcom,llcc-ecc" and "qcom,llcc-amon" bindings doesn't seem to be
used by the driver in patch 2, and it's not clear how they are intended
to be used, so I think they should go from the binding for now.

I don't think you need syscon and simple-mfd, and I think you can
simplify the binding to a single node like:

qcom,system-cache@1300000 {
compatible = "qcom,sdm845-llcc";
reg = <0x1300000 0x50000>;
#cache-slice-cells = <1>;
max-slices = <32>;
}

If ECC and AMON are option features, we can always add boolean
properties for those later, e.g. "has-ecc".

Thanks,
Mark.

\
 
 \ /
  Last update: 2018-02-01 11:48    [W:0.111 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site