lkml.org 
[lkml]   [2018]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v11 5/8] interconnect: qcom: Add sdm845 interconnect provider driver
Hi Georgi,

not a full review, only one thing I just stumbled across:

On Fri, Dec 07, 2018 at 05:29:14PM +0200, Georgi Djakov wrote:
> From: David Dai <daidavid1@codeaurora.org>
>
> Introduce Qualcomm SDM845 specific provider driver using the
> interconnect framework.
>
> Signed-off-by: David Dai <daidavid1@codeaurora.org>
> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
> ---
> .../bindings/interconnect/qcom,sdm845.txt | 24 +
> drivers/interconnect/Kconfig | 5 +
> drivers/interconnect/Makefile | 1 +
> drivers/interconnect/qcom/Kconfig | 13 +
> drivers/interconnect/qcom/Makefile | 5 +
> drivers/interconnect/qcom/sdm845.c | 836 ++++++++++++++++++
> .../dt-bindings/interconnect/qcom,sdm845.h | 143 +++
> 7 files changed, 1027 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,sdm845.txt
> create mode 100644 drivers/interconnect/qcom/Kconfig
> create mode 100644 drivers/interconnect/qcom/Makefile
> create mode 100644 drivers/interconnect/qcom/sdm845.c
> create mode 100644 include/dt-bindings/interconnect/qcom,sdm845.h
>
> ...
>
> diff --git a/drivers/interconnect/qcom/sdm845.c b/drivers/interconnect/qcom/sdm845.c
> new file mode 100644
> index 000000000000..f594dd6f500f
> --- /dev/null
> +++ b/drivers/interconnect/qcom/sdm845.c
>
> ...
>
> +static int qcom_icc_bcm_init(struct qcom_icc_bcm *bcm, struct device *dev)
> +{
> + struct qcom_icc_node *qn;
> + int ret, i;
> +
> + bcm->addr = cmd_db_read_addr(bcm->name);
> + if (!bcm->addr) {
> + dev_err(dev, "%s could not find RPMh address\n",
> + bcm->name);
> + return -EINVAL;
> + }
> +
> + if (cmd_db_read_aux_data_len(bcm->name) < sizeof(struct bcm_db)) {
> + dev_err(dev, "%s command db missing or partial aux data\n",
> + bcm->name);
> + return -EINVAL;
> + }

cmd_db_read_aux_data_len() is in the process of being removed, see
ed3cafa79ea7 ("soc: qcom: cmd-db: Stop memcpy()ing in
cmd_db_read_aux_data()") in arm-soc/for-next

https://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git/commit/?h=for-next&id=ed3cafa79ea756be653d22087c017af95ea78a49

Cheers

Matthias

\
 
 \ /
  Last update: 2018-12-08 00:31    [W:0.103 / U:3.592 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site