lkml.org 
[lkml]   [2018]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] x86/fault: Decode and print #PF oops in human readable form
On Fri, Dec 7, 2018 at 2:06 PM Sean Christopherson
<sean.j.christopherson@intel.com> wrote:
>
> Looking at it again, my own personal preference would be to swap the order
> of the #PF lines.

Yeah, probably.

Also:

> [ 160.246820] BUG: unable to handle kernel paging request at ffffbeef00000000
> [ 160.247517] #PF: supervisor-privileged instruction fetch from kernel code
> [ 160.248085] #PF: error_code(0x0010) - not-present page

With this form, I think the "kernel" in the first line is actually
misleading. Yes, it's a #PF for the kernel, but then the "kernel" on
the second line talks about what mode we were in when it happened, so
we have two different meanings of "kernel" on two adjacent lines.

So maybe that "BUG: unable to handle kernel paging request" message
should be something like

"BUG: unable to handle page fault for address ffffbeef00000000"

instead? Does that make sense to people?

Anyway, enough bike-shedding from me, I'll just shut up about this,
since I don't really care all that deeply, and I wasn't really the
target audience anyway. Sorry for the noise, and I'll leave the
decision to the people who actually wanted this.

Linus
[unhandled content-type:application/pkcs7-signature]
\
 
 \ /
  Last update: 2018-12-07 23:15    [W:0.064 / U:6.264 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site