lkml.org 
[lkml]   [2018]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] checkstack.pl: fix for aarch64
From
Date
On Fri, 2018-12-07 at 12:24 -0800, Andrew Morton wrote:
> On Fri,  7 Dec 2018 14:58:43 -0500 Qian Cai <cai@lca.pw> wrote:
>
> > There is actually a space after "sp," like this,
> >
> > ffff2000080813c8:       a9bb7bfd        stp     x29, x30, [sp, #-80]!
> >
>
> Confused.  Why does this matter?  Why is the patched version superior?

<Resend in plain text.>

Right now, checkstack.pl won’t be able to  print anything on aarch64, because it
won’t be able to match the stating objdump line of a function due to this
missing space. Hence, it saw every stack is zero-size.

After applied this patch, checkpatch.pl is able to match the start of a
function’s objdump, and then be able to calculate each function’s stack
correctly.

\
 
 \ /
  Last update: 2018-12-07 21:47    [W:0.067 / U:0.016 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site