lkml.org 
[lkml]   [2018]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] x86/fault: Decode and print #PF oops in human readable form
On Fri, Dec 7, 2018 at 11:52 AM Sean Christopherson
<sean.j.christopherson@intel.com> wrote:
>
> Remove the per-bit decoding of the error code and instead print:

The patch looks fine to me, so feel free to add an acked-by, but:

(a) I'm not the one who wanted the human-legible version in the first
place, since I'm also perfectly ok with just the error code, so my
judgement is obviously garbage wrt this whole thing

(b) it would be good to have a couple of actual examples of the
printout to judge.

I can certainly imagine how it looks just from the patch, but maybe if
I actually see reality I'd go "eww". Or somebody else goes "eww".

Linus
[unhandled content-type:application/pkcs7-signature]
\
 
 \ /
  Last update: 2018-12-07 21:47    [W:0.091 / U:2.136 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site