lkml.org 
[lkml]   [2018]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 1/2] spi: Add Renesas R-Car Gen3 RPC SPI controller driver
From
Date
On 12/07/2018 07:17 PM, Sergei Shtylyov wrote:
> Hello!
>
> I'd already started the v2 driver review before you posted v3, so here goes...
>
> On 12/03/2018 12:18 PM, Mason Yang wrote:
>
>> Add a driver for Renesas R-Car Gen3 RPC SPI controller.
>>
>> Signed-off-by: Mason Yang <masonccyang@mxic.com.tw>
> [...]
>> diff --git a/drivers/spi/spi-renesas-rpc.c b/drivers/spi/spi-renesas-rpc.c
>> new file mode 100644
>> index 0000000..ac9094e
>> --- /dev/null
>> +++ b/drivers/spi/spi-renesas-rpc.c
>> @@ -0,0 +1,808 @@
> [...]
>> +#define RPC_CMNCR 0x0000 /* R/W */
>> +#define RPC_CMNCR_MD BIT(31)
>> +#define RPC_CMNCR_SFDE BIT(24)
>
> This bit is undocumented as of the gen3 manual v1.0. I'd like this to be reflected
> in a comment...

FYI, not even in v1.50 .

--
Best regards,
Marek Vasut

\
 
 \ /
  Last update: 2018-12-07 19:24    [W:0.169 / U:4.984 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site