lkml.org 
[lkml]   [2018]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kprobes: x86_64: blacklist non-attachable interrupt functions
On Thu, 6 Dec 2018 10:56:48 +0100
Andrea Righi <righi.andrea@gmail.com> wrote:

> These interrupt functions are already non-attachable by kprobes.
> Blacklist them explicitly so that they can show up in
> /sys/kernel/debug/kprobes/blacklist and tools like BCC can use this
> additional information.
>
> Signed-off-by: Andrea Righi <righi.andrea@gmail.com>

For the short term, this is OK. But this is not the best way to cover
other functions which are also prohibited by arch_within_kprobe_blacklist().
I'll fix this issue later.

Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

Thank you,

> ---
> arch/x86/entry/entry_64.S | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S
> index ce25d84023c0..1f0efdb7b629 100644
> --- a/arch/x86/entry/entry_64.S
> +++ b/arch/x86/entry/entry_64.S
> @@ -566,6 +566,7 @@ ENTRY(interrupt_entry)
>
> ret
> END(interrupt_entry)
> +_ASM_NOKPROBE(interrupt_entry)
>
>
> /* Interrupt entry/exit. */
> @@ -766,6 +767,7 @@ native_irq_return_ldt:
> jmp native_irq_return_iret
> #endif
> END(common_interrupt)
> +_ASM_NOKPROBE(common_interrupt)
>
> /*
> * APIC interrupts.
> @@ -780,6 +782,7 @@ ENTRY(\sym)
> call \do_sym /* rdi points to pt_regs */
> jmp ret_from_intr
> END(\sym)
> +_ASM_NOKPROBE(\sym)
> .endm
>
> /* Make sure APIC interrupt handlers end up in the irqentry section: */
> @@ -960,6 +963,7 @@ ENTRY(\sym)
>
> jmp error_exit
> .endif
> +_ASM_NOKPROBE(\sym)
> END(\sym)
> .endm
>
> --
> 2.17.1


--
Masami Hiramatsu <mhiramat@kernel.org>

\
 
 \ /
  Last update: 2018-12-07 15:48    [W:0.085 / U:31.148 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site