[lkml]   [2018]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] usb: dwc2: Revert "usb: dwc2: Disable all EP's on disconnect"


Minas Harutyunyan <> writes:

> Hi Marek,
> On 12/6/2018 7:04 PM, Marek Szyprowski wrote:
>> Dear Minas,
>> On 2018-12-04 13:34, Minas Harutyunyan wrote:
>>> On 11/23/2018 6:43 PM, Dan Carpenter wrote:
>>>> Ugh... We also had a long thread about the v2 patch but it turns out
>>>> the list was not CC'd. I should have checked for that.
>>>> You have to pass a flag to say if the caller holds the lock or not...
>>>> regards,
>>>> dan carpenter
>>> Hi Dan, Marek, Maynard,
>>> Could you please apply bellow patch over follow patches:
>>> dccf1bad4be7 usb: dwc2: Disable all EP's on disconnect
>>> 6f774b501928 usb: dwc2: Fix ep disable spinlock flow.
>>> Please review and test. Feedback is appreciated :-)
>> Okay, I finally managed to find some time to check this. Your diff is
>> mangled, so I had to manually apply it. Frankly, it is very similar to
>> the revert I proposed. I've checked it on my test machines and it fixes
>> the issues. I'm not very happy about the unlock/lock design, but it
>> should be safe in this case and doesn't make the code even more complex.
>> Feel free to add a following tag to the final patch:
>> Tested-by: Marek Szyprowski <>
> Thanks for testing.

should $Subject be applied? Can you resend rebased on testing/next with
Tested-by tags collected if you're happy with it?



 \ /
  Last update: 2018-12-07 10:50    [W:0.073 / U:1.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site