Messages in this thread |  | | Subject | Re: [PATCH 04/14] dt-bindings: timer: Add Milbeaut M10V timer description | From | "Sugaya, Taichi" <> | Date | Thu, 6 Dec 2018 16:42:04 +0900 |
| |
Hi,
Thank you for your comments.
On 2018/12/05 8:03, Rob Herring wrote: > On Mon, Nov 19, 2018 at 10:01:09AM +0900, Sugaya Taichi wrote: >> Add DT bindings document for Milbeaut M10V timer. >> >> Signed-off-by: Sugaya Taichi <sugaya.taichi@socionext.com> >> --- >> .../bindings/timer/socionext,milbeaut-timer.txt | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/timer/socionext,milbeaut-timer.txt >> >> diff --git a/Documentation/devicetree/bindings/timer/socionext,milbeaut-timer.txt b/Documentation/devicetree/bindings/timer/socionext,milbeaut-timer.txt >> new file mode 100644 >> index 0000000..ddb1b31 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/timer/socionext,milbeaut-timer.txt >> @@ -0,0 +1,17 @@ >> +Milbeaut SoCs Timer Controller >> + >> +Required properties: >> + >> +- compatible : should be "socionext,milbeaut-m10v-timer" >> +- reg : Specifies base physical address and size of the registers. > > How many register ranges? Looks like 2.
Yes, has two ranges. So add the description about it.
> >> +- interrupts : The interrupt of the first timer >> +- clocks: should be "rclk" >> + >> +Example: >> + >> +timer { > > timer@1e000050
Okay.
Thanks Sugaya Taichi
> >> + compatible = "socionext,milbeaut-m10v-timer"; >> + reg = <0x1e000050 0x10>, <0x1e000060 0x10>; >> + interrupts = <0 91 4>; >> + clocks = <&rclk>; >> +}; >> -- >> 1.9.1 >>
|  |