[lkml]   [2018]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v14 00/11] livepatch: Atomic replace feature
On Thu 2018-12-06 10:32:00, Miroslav Benes wrote:
> > > I don't have many code comments as the changes appear to safely and
> > > correctly do what the say. (We are at v14 after all :) I mainly
> > > compared the text and comments to the implementation and noted typos
> > > (marked by substitution s/old/new) and awkward wordings (marked by
> > > "re-wording suggestion"). That said, I ack'd each patch as I wouldn't
> > > want these to hold up the patchset.
> >
> > Thanks a lot both you and Miroslav for the review.
> >
> > I'll give it some more days before I prepare v15. I wonder if Josh
> > could find some cycle to look at it at least from the top level.
> For what is worth, I'm fine with all the changes Joe proposed and you can
> preserve my acks there.

We need enough time for bikeshedding about comments and documentation.
I need some time to recover. And I still hope that Josh can give it
a spin.

Best Regards,

 \ /
  Last update: 2018-12-06 11:16    [W:0.088 / U:7.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site