lkml.org 
[lkml]   [2018]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/7] microblaze: move "... is ready" message to arch/microblaze/Makefile
From
Date
On 03. 12. 18 8:50, Masahiro Yamada wrote:
> To prepare for more fixes, move this to arch/microblaze/Makefile.
> Otherwise, the same "... is ready" would be printed multiple times.
>
> (Another solution would be, to remove these messages entirely unless
> people persist with them.)
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> arch/microblaze/Makefile | 2 ++
> arch/microblaze/boot/Makefile | 4 ----
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/arch/microblaze/Makefile b/arch/microblaze/Makefile
> index 97e1384..cfd7bfca 100644
> --- a/arch/microblaze/Makefile
> +++ b/arch/microblaze/Makefile
> @@ -81,9 +81,11 @@ archclean:
>
> linux.bin linux.bin.gz linux.bin.ub: vmlinux
> $(Q)$(MAKE) $(build)=$(boot) $(boot)/$@
> + @echo 'Kernel: $(boot)/$@ is ready' ' (#'`cat .version`')'
>
> simpleImage.%: vmlinux
> $(Q)$(MAKE) $(build)=$(boot) $(boot)/$@
> + @echo 'Kernel: $(boot)/$@ is ready' ' (#'`cat .version`')'
>
> define archhelp
> echo '* linux.bin - Create raw binary'
> diff --git a/arch/microblaze/boot/Makefile b/arch/microblaze/boot/Makefile
> index e8684a2..c2579a7 100644
> --- a/arch/microblaze/boot/Makefile
> +++ b/arch/microblaze/boot/Makefile
> @@ -9,15 +9,12 @@ OBJCOPYFLAGS := -R .note -R .comment -R .note.gnu.build-id -O binary
>
> $(obj)/linux.bin: vmlinux FORCE
> $(call if_changed,objcopy)
> - @echo 'Kernel: $@ is ready' ' (#'`cat .version`')'
>
> $(obj)/linux.bin.ub: $(obj)/linux.bin FORCE
> $(call if_changed,uimage)
> - @echo 'Kernel: $@ is ready' ' (#'`cat .version`')'
>
> $(obj)/linux.bin.gz: $(obj)/linux.bin FORCE
> $(call if_changed,gzip)
> - @echo 'Kernel: $@ is ready' ' (#'`cat .version`')'
>
> quiet_cmd_cp = CP $< $@$2
> cmd_cp = cat $< >$@$2 || (rm -f $@ && echo false)
> @@ -35,6 +32,5 @@ $(obj)/simpleImage.%: vmlinux FORCE
> $(call if_changed,objcopy)
> $(call if_changed,uimage)
> $(call if_changed,strip,.strip)
> - @echo 'Kernel: $(UIMAGE_OUT) is ready' ' (#'`cat .version`')'
>
> clean-files += simpleImage.*
>

TBH I can't see this problematic but if this is aligned with others I
have no problem with it.

Thanks,
Michal


--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs


[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2018-12-05 16:49    [W:0.230 / U:11.484 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site