lkml.org 
[lkml]   [2018]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 07/14] clock: milbeaut: Add Milbeaut M10V clock control
From
Date
Hi

On 2018/12/05 3:15, Stephen Boyd wrote:
> Quoting Sugaya, Taichi (2018-12-04 00:26:16)
>> On 2018/11/30 17:31, Stephen Boyd wrote:
>>> Quoting Sugaya Taichi (2018-11-18 17:01:12)
>>>> +void __init m10v_clk_mux_setup(struct device_node *node)
>>>> +{
>>>> + const char *clk_name = node->name;
>>>> + struct clk_init_data init;
>>>> + const char **parent_names;
>>>> + struct m10v_mux *mcm;
>>>> + struct clk *clk;
>>>> + int i, parents;
>>>> +
>>>> + if (!m10v_clk_iomap())
>>>> + return;
>>>> +
>>>> + of_property_read_string(node, "clock-output-names", &clk_name);
>>>> +
>>>> + parents = of_clk_get_parent_count(node);
>>>> + if (parents < 2) {
>>>> + pr_err("%s: not a mux\n", clk_name);
>>>
>>> How is this possible?
>>
>> When the node has more than 1 clks...
>> Or I am misunderstanding your question?
>
> This looks like code that's checking DT for correctness. We don't
> typically do that in the kernel because the kernel isn't a DT validator.
> That's all I'm saying. I think this comment is not useful if the driver
> design is done to specify parent linkages in C code instead of DT, so
> don't worry about this too much.

I understand.
Thank you for additional information.

Sugaya Taichi

>

\
 
 \ /
  Last update: 2018-12-05 12:43    [W:0.076 / U:0.724 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site