lkml.org 
[lkml]   [2018]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] perf: tests: Disable breakpoint tests on ARM (32-bit)
Em Tue, Dec 04, 2018 at 02:06:16PM +0000, Will Deacon escreveu:
> On Mon, Dec 03, 2018 at 11:11:36AM -0800, Florian Fainelli wrote:
> > breakpoint tests on the ARM 32-bit kernel are broken in several ways.
> >
> > The breakpoint length requested does not necessarily match whether the
> > function address has the Thumb bit (bit 0) set or not, and this does
> > matter to the ARM kernel hw_breakpoint infrastructure. See [1] for
> > background.
> >
> > [1]: https://lkml.org/lkml/2018/11/15/205
> >
> > As Will indicated, the overflow handling would require single-stepping
> > which is not supported at the moment. Just disable those tests for the
> > ARM 32-bit platforms and update the comment above to explain these
> > limitations.
> >
> > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> > ---
> > Changes in v3:
> >
> > - directly incorporate Will's comment, Will can you add your
> > Signed-off-by?
>
> Of course:
>
> Co-developed-by: Will Deacon <will.deacon@arm.com>
> Signed-off-by: Will Deacon <will.deacon@arm.com>

Thanks, added those and applied the patch.

- Arnaldo

\
 
 \ /
  Last update: 2018-12-04 15:13    [W:0.063 / U:1.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site