lkml.org 
[lkml]   [2018]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC v3 18/19] of: unittest: split out a couple of test cases from unittest
From
Date
Hi Brendan,

On 11/28/18 11:36 AM, Brendan Higgins wrote:
> Split out a couple of test cases that these features in base.c from the
> unittest.c monolith. The intention is that we will eventually split out
> all test cases and group them together based on what portion of device
> tree they test.

Why does splitting this file apart improve the implementation?


>
> Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
> ---
> drivers/of/Makefile | 2 +-
> drivers/of/base-test.c | 214 ++++++++++++++++++++++++++
> drivers/of/test-common.c | 149 ++++++++++++++++++
> drivers/of/test-common.h | 16 ++
> drivers/of/unittest.c | 316 +--------------------------------------
> 5 files changed, 381 insertions(+), 316 deletions(-)
> create mode 100644 drivers/of/base-test.c
> create mode 100644 drivers/of/test-common.c
> create mode 100644 drivers/of/test-common.h
>
< snip >

-Frank

\
 
 \ /
  Last update: 2018-12-04 12:29    [W:0.547 / U:23.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site