[lkml]   [2018]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH v2] firmware: stratix10-svc: fix wrong of_node_put() in init function
After finding a "firmware" dt node stratix10 tries to match it's
compatible string with it. To do so it's calling of_find_matching_node()
which already takes care of decreasing the refcount on the "firmware"
node. We are then incorrectly decreasing the refcount on that node

This patch removes the unwarranted call to of_node_put().

Fixes: 7ca5ce896524 ("firmware: add Intel Stratix10 service layer driver")
Signed-off-by: Nicolas Saenz Julienne <>
v1 -> v2: add actual people to CC & remove unnecessary braces

drivers/firmware/stratix10-svc.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/firmware/stratix10-svc.c b/drivers/firmware/stratix10-svc.c
index 81f3182e290d..6e6514825ad0 100644
--- a/drivers/firmware/stratix10-svc.c
+++ b/drivers/firmware/stratix10-svc.c
@@ -1016,14 +1016,11 @@ static int __init stratix10_svc_init(void)
return -ENODEV;

np = of_find_matching_node(fw_np, stratix10_svc_drv_match);
- if (!np) {
- of_node_put(fw_np);
+ if (!np)
return -ENODEV;
- }

ret = of_platform_populate(fw_np, stratix10_svc_drv_match, NULL, NULL);
- of_node_put(fw_np);
if (ret)
return ret;

 \ /
  Last update: 2018-12-03 18:28    [W:0.028 / U:10.996 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site