lkml.org 
[lkml]   [2018]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Xen-devel] [PATCH 2/2] xen-pciback: Allow enabling/disabling expansion ROM
>>> On 03.12.18 at 15:47, <marmarek@invisiblethingslab.com> wrote:
> On Mon, Dec 03, 2018 at 04:01:07AM -0700, Jan Beulich wrote:
>> >>> On 02.12.18 at 18:47, <marmarek@invisiblethingslab.com> wrote:
>> > From: Dwayne Litzenberger <dlitz@dlitz.net>
>> >
>> > Newer AMD GPUs store their initialization routines as bytecode on the
>> > ROM. This fixes the following initialization error inside the VM when
>> > doing PCI passthrough:
>> >
>> > radeon 0000:00:05.0: Invalid PCI ROM header signature: expecting 0xaa55, got 0xffff
>> > radeon 0000:00:05.0: Invalid PCI ROM header signature: expecting 0xaa55, got 0xffff
>> > [drm:radeon_get_bios [radeon]] *ERROR* Unable to locate a BIOS ROM
>> > radeon 0000:00:05.0: Fatal error during GPU init
>>
>> Isn't it that qemu is supposed to surface the ROM image to guests,
>> making it unnecessary to allow guests control over the physical
>> enable bit?
>
> Unless that qemu is in stubdomain, where it use pciback to access
> everything about the device...

Would be quite helpful to explain this in the description.

>> Also why would allowing to alter the bit depend on
>> whether the address portion of the value is non-zero?
>
> That's a good question. According to commit message I think it should be
> a ROM presence check instead. If needed at this point at all - is this
> function even called if there is no ROM?

I suppose this was a question to Dwayne, not me.

Jan


\
 
 \ /
  Last update: 2018-12-03 16:05    [W:0.076 / U:4.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site