lkml.org 
[lkml]   [2018]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/4] clk: core: link consumer with clock driver
Hello,

kbuild test robot <lkp@intel.com> wrote on Sat, 1 Dec 2018 08:29:05
+0800:

> Hi Miquel,
>
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on clk/clk-next]
> [also build test ERROR on v4.20-rc4 next-20181130]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/Miquel-Raynal/Add-device-links-to-clocks/20181201-074305
> base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
> config: i386-randconfig-x071-201847 (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=i386
>
> All errors (new ones prefixed by >>):
>
> >> drivers//clk/clkdev.c:115:13: error: static declaration of 'clk_link_consumer' follows non-static declaration
> static void clk_link_consumer(struct device *consumer, struct clk *clk) {}
> ^~~~~~~~~~~~~~~~~
> In file included from drivers//clk/clkdev.c:22:0:
> include/linux/clk-provider.h:784:6: note: previous declaration of 'clk_link_consumer' was here
> void clk_link_consumer(struct device *consumer, struct clk *clk);
> ^~~~~~~~~~~~~~~~~
> >> drivers//clk/clkdev.c:116:13: error: static declaration of 'clk_unlink_consumer' follows non-static declaration
> static void clk_unlink_consumer(struct clk *clk) {}
> ^~~~~~~~~~~~~~~~~~~
> In file included from drivers//clk/clkdev.c:22:0:
> include/linux/clk-provider.h:785:6: note: previous declaration of 'clk_unlink_consumer' was here
> void clk_unlink_consumer(struct clk *clk);
> ^~~~~~~~~~~~~~~~~~~
>
> vim +/clk_link_consumer +115 drivers//clk/clkdev.c
>
> 114
> > 115 static void clk_link_consumer(struct device *consumer, struct clk *clk) {}
> > 116 static void clk_unlink_consumer(struct clk *clk) {}
> 117
>

Both functions should not be static. I will remove the keyword in a v3.


Thanks,
Miquèl

\
 
 \ /
  Last update: 2018-12-03 15:32    [W:0.061 / U:5.468 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site