lkml.org 
[lkml]   [2018]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v8 2/3] x86: add support for Huawei WMI hotkeys.
On Mon, 03 Dec 2018 15:18:54 +0100,
Andy Shevchenko wrote:
>
> On Mon, Dec 3, 2018 at 2:00 PM Takashi Iwai <tiwai@suse.de> wrote:
> > On Fri, 30 Nov 2018 00:57:37 +0100,
> > Ayman Bagabas wrote:
>
> > > +struct huawei_wmi_priv {
> > > + struct input_dev *idev;
> > > + struct led_classdev cdev;
> > > + acpi_handle handle;
> >
> > Is this handle set in anywhere? I couldn't see it in your patch.
> > If it's supposed to be NULL, passing NULL explicitly makes your
> > intention clearer.
>
> Isn't below an answer?
>
> > > + // Skip registering LED subsystem if no ACPI method was found.
> > > + status = acpi_get_handle(priv->handle, "\\_SB.PCI0.LPCB.EC0", &priv->handle);

Oh indeed, but why it passes priv->handle at the first argument...?


thanks,

Takashi

\
 
 \ /
  Last update: 2018-12-03 15:22    [W:0.054 / U:0.916 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site