lkml.org 
[lkml]   [2018]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2] x86/hyper-v: Mark TLFS structures packed
Date
Michael Kelley <mikelley@microsoft.com> writes:

> From: Vitaly Kuznetsov <vkuznets@redhat.com> Sent: Friday, November 30, 2018 4:54 AM
>>
>> @@ -466,7 +466,7 @@ union hv_message_flags {
>> struct {
>> __u8 msg_pending:1;
>> __u8 reserved:7;
>> - };
>> + } __packed;
>> };
>>
>> /* Define port identifier type. */
>
> I think __packed is also needed in the definition
> of struct u defined within union hv_port_id. That
> struct has bit fields, so shouldn't it be done just like
> union hv_message_flags above?
>

True, missed it, thanks! Will send v3 out shortly.

--
Vitaly

\
 
 \ /
  Last update: 2018-12-03 14:46    [W:0.099 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site