lkml.org 
[lkml]   [2018]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/8] mfd / platform: cros_ec: use devm_mfd_add_devices.
On Tue, 27 Nov 2018, Enric Balletbo i Serra wrote:

> Use devm_mfd_add_devices() for adding cros-ec core MFD child devices. This
> reduces the need of remove callback from platform/chrome for removing the
> MFD child devices.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
>
> Changes in v3:
> - Removed cros_ec_remove from include file.
>
> Changes in v2:
> - Use devm only for the cros-ec core.
>
> drivers/mfd/cros_ec.c | 14 +++-----------
> drivers/mfd/cros_ec_dev.c | 1 +
> drivers/platform/chrome/cros_ec_i2c.c | 10 ----------
> drivers/platform/chrome/cros_ec_lpc.c | 4 ----
> drivers/platform/chrome/cros_ec_spi.c | 11 -----------
> include/linux/mfd/cros_ec.h | 10 ----------
> 6 files changed, 4 insertions(+), 46 deletions(-)

Nice patch.

Just one question:

[...]

> diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
> index 8f9d6964173e..ff788d3e6d5f 100644
> --- a/drivers/mfd/cros_ec_dev.c
> +++ b/drivers/mfd/cros_ec_dev.c
> @@ -493,6 +493,7 @@ static int ec_device_remove(struct platform_device *pdev)
>
> cros_ec_debugfs_remove(ec);
>
> + mfd_remove_devices(ec->dev);

Why is this still required?

> cdev_del(&ec->cdev);
> device_unregister(&ec->class_dev);
> return 0;

[...]

--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

\
 
 \ /
  Last update: 2018-12-03 11:33    [W:0.244 / U:2.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site