lkml.org 
[lkml]   [2018]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: trigger named just "tx" in drivers/net/wireless/atmel/at76c50x-usb.c
Date
Pavel Machek <pavel@ucw.cz> writes:

> While grepping something else, I came across LED trigger that is named
> just "tx".
>
> That's a bit too generic afaict?
>
> +++ b/drivers/net/wireless/atmel/at76c50x-usb.c
> @@ -520,7 +520,7 @@ static int at76_usbdfu_download(struct usb_device
> *udev, u8 *buf, u32 size,
> static int tx_activity;
> static void at76_ledtrig_tx_timerfunc(struct timer_list *unused);
> static DEFINE_TIMER(ledtrig_tx_timer, at76_ledtrig_tx_timerfunc);
> -DEFINE_LED_TRIGGER(ledtrig_tx);
> +DEFINE_LED_TRIGGER(ledtrig_tx); /* Hey! "tx" is a bit too generic
> name for a trigger! */

This is an ancient driver, my guess is that nobody uses it anymore. I
should orphan it and maybe even remove it at some point.

--
Kalle Valo

\
 
 \ /
  Last update: 2018-12-03 09:46    [W:0.055 / U:0.992 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site