lkml.org 
[lkml]   [2018]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: + taint-fix-debugfs_simple_attrcocci-warnings.patch added to -mm tree
On (12/28/18 13:54), akpm@linux-foundation.org wrote:
>
> Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE
> for debugfs files.
>
> Semantic patch information:
> Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file()
> imposes some significant overhead as compared to
> DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe().

Looks OK to me.

Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>

> static __init int register_warn_debugfs(void)
> {
> /* Don't care about failure */
> - debugfs_create_file("clear_warn_once", 0200, NULL,
> - NULL, &clear_warn_once_fops);
> + debugfs_create_file_unsafe("clear_warn_once", 0200, NULL, NULL,
> + &clear_warn_once_fops);
> return 0;
> }

The commit message probably can be better.

The _unsafe() part suggests that some of them "safeness responsibilities"
are now panic.c responsibilities. The patch is OK since panic's
clear_warn_once_fops struct file_operations is safe against removal, so we
don't have to use otherwise necessary debugfs_file_get()/debugfs_file_put().

-ss

\
 
 \ /
  Last update: 2018-12-30 05:04    [W:0.041 / U:0.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site