lkml.org 
[lkml]   [2018]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 12/22] mmc: core: Allow BKOPS and CACHE ctrl even if no HPI support
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Ulf Hansson <ulf.hansson@linaro.org>

    commit ba9f39a785a9977e72233000711ef1eb48203551 upstream.

    In commit 5320226a0512 ("mmc: core: Disable HPI for certain Hynix eMMC
    cards"), then intent was to prevent HPI from being used for some eMMC
    cards, which didn't properly support it. However, that went too far, as
    even BKOPS and CACHE ctrl became prevented. Let's restore those parts and
    allow BKOPS and CACHE ctrl even if HPI isn't supported.

    Fixes: 5320226a0512 ("mmc: core: Disable HPI for certain Hynix eMMC cards")
    Cc: Pratibhasagar V <pratibha@codeaurora.org>
    Cc: <stable@vger.kernel.org>
    Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/mmc/core/mmc.c | 6 ++----
    1 file changed, 2 insertions(+), 4 deletions(-)

    --- a/drivers/mmc/core/mmc.c
    +++ b/drivers/mmc/core/mmc.c
    @@ -522,8 +522,7 @@ static int mmc_decode_ext_csd(struct mmc
    card->cid.year += 16;

    /* check whether the eMMC card supports BKOPS */
    - if (!mmc_card_broken_hpi(card) &&
    - ext_csd[EXT_CSD_BKOPS_SUPPORT] & 0x1) {
    + if (ext_csd[EXT_CSD_BKOPS_SUPPORT] & 0x1) {
    card->ext_csd.bkops = 1;
    card->ext_csd.man_bkops_en =
    (ext_csd[EXT_CSD_BKOPS_EN] &
    @@ -1730,8 +1729,7 @@ static int mmc_init_card(struct mmc_host
    * If cache size is higher than 0, this indicates
    * the existence of cache and it can be turned on.
    */
    - if (!mmc_card_broken_hpi(card) &&
    - card->ext_csd.cache_size > 0) {
    + if (card->ext_csd.cache_size > 0) {
    err = mmc_switch(card, EXT_CSD_CMD_SET_NORMAL,
    EXT_CSD_CACHE_CTRL, 1,
    card->ext_csd.generic_cmd6_time);

    \
     
     \ /
      Last update: 2018-12-28 13:20    [W:4.605 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site