lkml.org 
[lkml]   [2018]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] net: sfc: checks status of efx_mcdi_rpc
From
From: Kangjie Lu <kjlu@umn.edu>
Date: Tue, 25 Dec 2018 23:05:17 -0600

> efx_mcdi_rpc() could fail. The fix checks its status and issues an error
> message if it fails.
>
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
> ---
> drivers/net/ethernet/sfc/mcdi.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/ethernet/sfc/mcdi.c b/drivers/net/ethernet/sfc/mcdi.c
> index dfad93fca0a6..9486e6534dea 100644
> --- a/drivers/net/ethernet/sfc/mcdi.c
> +++ b/drivers/net/ethernet/sfc/mcdi.c
> @@ -1819,6 +1819,9 @@ void efx_mcdi_set_id_led(struct efx_nic *efx, enum efx_led_mode mode)
>
> rc = efx_mcdi_rpc(efx, MC_CMD_SET_ID_LED, inbuf, sizeof(inbuf),
> NULL, 0, NULL);
> + if (rc)
> + netif_err(efx, hw, efx->net_dev, "%s: failed rc=%d\n",
> + __func__, rc);

"__func__" did not fail, efx_mcdi_rpc() did.

\
 
 \ /
  Last update: 2018-12-28 01:25    [W:0.043 / U:10.664 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site