lkml.org 
[lkml]   [2018]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] rtc: rv8803: Check return value of rv8803_write_reg
From
Date
On 27.12.2018 21:28, Aditya Pakki wrote:
> In rv8803_handle_irq, rv8803_write_reg can return a failed return
> value when attempting to write to the bus. The fix checks the output
> and throws a dev_warn notifying of the failure.
>
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
> ---
> drivers/rtc/rtc-rv8803.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
You seem to submit the same type of changes throughout very
different subsystems. And you do it w/o thinking and testing.
If you would have looked at rv8803_write_reg() you would have
seen that it prints an error in case of failure. So your
patch achieves nothing.
You got David Miller upset already and it looks like you
want to achieve the same with other maintainers too.
I'd strongly suggest that you stop sending patches until
you better understand the kernel code.




\
 
 \ /
  Last update: 2018-12-27 23:33    [W:0.080 / U:2.608 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site