lkml.org 
[lkml]   [2018]   [Dec]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fs: proc: check status of register_filesystem
On Wed, Dec 26, 2018 at 09:18:56AM +0300, Alexey Dobriyan wrote:
> On Tue, Dec 25, 2018 at 09:06:40PM -0600, Kangjie Lu wrote:
> > register_filesystem() could fail. The fix issues an error message if it
> > fails.
>
> > - register_filesystem(&proc_fs_type);
> > + if (register_filesystem(&proc_fs_type))
> > + pr_err("failed to register the filesystem.\n");
>
> No, register_filesystem() should do it.

Folks, check when would it fail. If we have something called "proc"
already registered by the time when proc_root_init() runs... might
as well have been a panic().

\
 
 \ /
  Last update: 2018-12-26 08:00    [W:0.071 / U:19.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site