[lkml]   [2018]   [Dec]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] ubifs: Get/put page when changing PG_private
On 2018/12/21 下午4:56, Richard Weinberger wrote:
> Am Samstag, 15. Dezember 2018, 16:01:30 CET schrieb Richard Weinberger:
>> The page migration code assumes that a page with PG_private
>> set has its page count elevated by 1.
>> UBIFS never did this and therefore the migration code was unable
>> to migrate some pages owned by UBIFS.
>> The lead to situations where the CMA memory allocator failed to
>> allocate memory.
>> Fix this by using get/put_page when changing PG_private.
>> Cc: <>
>> Cc: zhangjun <>
>> Fixes: 4ac1c17b2044 ("UBIFS: Implement ->migratepage()")
>> Reported-by: zhangjun <>
>> Signed-off-by: Richard Weinberger <>
> FYI, on the XFS side a similar change caused a regression.
> Until this regression is not fully understood, including the implications
> for UBIFS, I'll not merge this patch.
> Thanks,
> //richard

Before fully understanding this regression, in order to fix the bug of
submit a conservative patch that modifies count in iomap_migrate_page().
Can you consider merging first?


 \ /
  Last update: 2018-12-25 03:43    [W:0.127 / U:0.616 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site