lkml.org 
[lkml]   [2018]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Staging: iio: adis16240: fixed a SPDX identifier tag mistake
On Wed, 19 Dec 2018 13:07:31 -0800
Amir Mahdi Ghorbanian <indigoomega021@gmail.com> wrote:

> Fixed a coding style mistake by adding the SPDX identifier tag to the
> first line of the code.
>
> Signed-off-by: Amir Mahdi Ghorbanian <indigoomega021@gmail.com>
*groans* Another one where the MODULE_LICENSE is different.
Michael, Analog copyright, so if you want to express a view on
the intent that would be great.

My feeling would be that the MODULE_LICENSE is the wrong one given it's
easier to get that wrong than to add an 'or later' to the text..

On these I generally want an ack from the copyright holder anyway
just to be sure everything is in order.

Thanks,

Jonathan

> ---
> drivers/staging/iio/accel/adis16240.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/accel/adis16240.c b/drivers/staging/iio/accel/adis16240.c
> index 24e525f..2c40189 100644
> --- a/drivers/staging/iio/accel/adis16240.c
> +++ b/drivers/staging/iio/accel/adis16240.c
> @@ -1,9 +1,9 @@
> +// SPDX-License-Identifier: GPL-2.0+
> /*
> * ADIS16240 Programmable Impact Sensor and Recorder driver
> *
> * Copyright 2010 Analog Devices Inc.
> *
> - * Licensed under the GPL-2 or later.
> */
>
> #include <linux/interrupt.h>

\
 
 \ /
  Last update: 2018-12-22 18:39    [W:0.040 / U:1.656 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site