lkml.org 
[lkml]   [2018]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [for-next][PATCH 2/5] tracing: Use str_has_prefix() helper for histogram code
On Sat, 22 Dec 2018 12:03:41 -0600
Tom Zanussi <zanussi@kernel.org> wrote:

> Hi Steve,
>
> On Sat, 2018-12-22 at 13:01 -0500, Steven Rostedt wrote:
> > On Sat, 22 Dec 2018 11:20:09 -0500
> > Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > > From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
> > >
> > > The tracing histogram code contains a lot of instances of the
> > > construct:
> > >
> > > strncmp(str, "const", sizeof("const") - 1)
> > >
> > > This can be prone to bugs due to typos or bad cut and paste. Use
> > > the
> > > str_has_prefix() helper macro instead that removes the need for
> > > having two
> > > copies of the constant string.
> > >
> > > Cc: Tom Zanussi <zanussi@linux.intel.com>
> >
> > I have no idea why I copied your intel email. The linux.intel.com
> > appears to be no longer active. I'm going to rebase to fix this email
> > address.
>
> linux.intel.com is active, but there's no zanussi there, just
> tom.zanussi ;-)
>
> So tom.zanussi@linux.intel.com should work fine.

BTW, would you give me your ack-by?

-- Steve

\
 
 \ /
  Last update: 2022-09-17 16:05    [W:0.352 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site