lkml.org 
[lkml]   [2018]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] m68k/mac: Use '030 reset method on SE/30
On Sat, 22 Dec 2018, Geert Uytterhoeven wrote:

> > - local_irq_save(flags);
> > -
> > - rom_reset();
> > -
> > - local_irq_restore(flags);
>
> I guess you removed the call to local_irq_restore() because you never
> get there anyway?
>

If a ROM call returns, we have a real problem, because we didn't call it
in an execution environment that it is designed to be called in. Anything
could happen.

Moreover, local_irq_restore() is bogus either way, given that there's
nothing that our interrupt handlers can usefully do now.

See also commit 558d5ad276c9 ("m68k/mac: Avoid soft-lockup warning after
mach_power_off").

--

\
 
 \ /
  Last update: 2018-12-23 00:05    [W:0.066 / U:16.116 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site