lkml.org 
[lkml]   [2018]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] serial: 8250: Default SERIAL_OF_PLATFORM to SERIAL_8250
On Wed, Nov 14, 2018 at 05:11:25PM -0800, Guenter Roeck wrote:
> On Thu, Nov 01, 2018 at 11:26:06AM -0700, Florian Fainelli wrote:
> > It is way too easy to miss enabling SERIAL_OF_PLATFORM which would
> > result in the inability for the kernel to have a valid console device,
> > which can be seen with:
> >
> > Warning: unable to open an initial console.
> >
> > and then:
> >
> > Run /init as init process
> > Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000100
> >
> > Since SERIAL_OF_PLATFORM already depends on SERIAL_8250 && OF there
> > really is no drawback to defaulting this config to the value of
> > SERIAL_8250.
> >
> > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> This patch results in situations where CONFIG_SERIAL_OF_PLATFORM is now
> defined where it was not previously. Example mpc85xx_defconfig. This in
> turn results in boot failures for those configurations, with an error
> message of
>
> of_serial: probe of e0004500.serial failed with error -22
>
> which wasn't seen before.
>
> Not sure if replacing a potential problem with a real one is really an
> improvement.`

What ever was the result of this long thread? Should I revert
something? Or was a patch proposed?

totally lost,

greg k-h

\
 
 \ /
  Last update: 2018-12-20 16:22    [W:0.103 / U:2.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site