lkml.org 
[lkml]   [2018]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] rtlwifi: Fix non-working BSS STA mode
From
Date


> On Dec 20, 2018, at 14:42, Kalle Valo <kvalo@codeaurora.org> wrote:
>
> Kai-Heng Feng <kai.heng.feng@canonical.com> wrote:
>
>> Once BSS STA mode gets started, it can be scanned by other clients but
>> cannot entablish a connection.
>>
>> Turns out the set_bcn_reg() and its *_set_beacon_related_registers()
>> callbacks never get called so it has problem beaconing.
>>
>> Enable the function in rtl_op_bss_info_changed() can make BSS STA mode
>> start to work.
>>
>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
>
> The commit log is quite misleading. It implies that the client mode is broken
> for all rtlwifi hardware and that can't be the case, otherwise we would be
> flooded by bug reports. So please improve the commit log and describe clearly
> the problem you are solving.

You are right. I'll wait for PKShih’s test result and update commit log afterwards.

Kai-Heng

>
> --
> https://patchwork.kernel.org/patch/10725537/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
>

\
 
 \ /
  Last update: 2018-12-20 13:56    [W:0.093 / U:9.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site