lkml.org 
[lkml]   [2018]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 32/41] scsi: myrb: Mark expected switch fall-throughs
From
Date
Hi,

Friendly ping:

Who can ack or review this patch, please?

Thanks
--
Gustavo

On 11/27/18 10:32 PM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Addresses-Coverity-ID: 1465234 ("Missing break in switch")
> Addresses-Coverity-ID: 1465238 ("Missing break in switch")
> Addresses-Coverity-ID: 1465242 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/scsi/myrb.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/scsi/myrb.c b/drivers/scsi/myrb.c
> index 0642f2d0a3bb..539ac8ce4fcd 100644
> --- a/drivers/scsi/myrb.c
> +++ b/drivers/scsi/myrb.c
> @@ -1528,6 +1528,7 @@ static int myrb_ldev_queuecommand(struct Scsi_Host *shost,
> scmd->scsi_done(scmd);
> return 0;
> }
> + /* fall through */
> case WRITE_6:
> lba = (((scmd->cmnd[1] & 0x1F) << 16) |
> (scmd->cmnd[2] << 8) |
> @@ -1544,6 +1545,7 @@ static int myrb_ldev_queuecommand(struct Scsi_Host *shost,
> scmd->scsi_done(scmd);
> return 0;
> }
> + /* fall through */
> case WRITE_10:
> case VERIFY: /* 0x2F */
> case WRITE_VERIFY: /* 0x2E */
> @@ -1560,6 +1562,7 @@ static int myrb_ldev_queuecommand(struct Scsi_Host *shost,
> scmd->scsi_done(scmd);
> return 0;
> }
> + /* fall through */
> case WRITE_12:
> case VERIFY_12: /* 0xAF */
> case WRITE_VERIFY_12: /* 0xAE */
>

\
 
 \ /
  Last update: 2018-12-20 01:07    [W:0.372 / U:1.784 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site