lkml.org 
[lkml]   [2018]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 19/41] scsi: isci: remote_node_context: mark expected switch fall-throughs
From
Date
Hi,

Friendly ping:

Who can ack or review this patch, please?

Thanks
--
Gustavo

On 11/27/18 10:30 PM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Notice that, in this particular case, a dash is added as a token in
> order to separate the "Fall through" annotations from the rest of
> the comment on the same line, which is what GCC is expecting to find.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/scsi/isci/remote_node_context.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/isci/remote_node_context.c b/drivers/scsi/isci/remote_node_context.c
> index e3f2a5359d71..474a43460963 100644
> --- a/drivers/scsi/isci/remote_node_context.c
> +++ b/drivers/scsi/isci/remote_node_context.c
> @@ -601,9 +601,9 @@ enum sci_status sci_remote_node_context_suspend(
> __func__, sci_rnc);
> return SCI_FAILURE_INVALID_STATE;
> }
> - /* Fall through and handle like SCI_RNC_POSTING */
> + /* Fall through - and handle like SCI_RNC_POSTING */
> case SCI_RNC_RESUMING:
> - /* Fall through and handle like SCI_RNC_POSTING */
> + /* Fall through - and handle like SCI_RNC_POSTING */
> case SCI_RNC_POSTING:
> /* Set the destination state to AWAIT - this signals the
> * entry into the SCI_RNC_READY state that a suspension
>

\
 
 \ /
  Last update: 2018-12-19 23:50    [W:0.368 / U:9.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site