lkml.org 
[lkml]   [2018]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 17/41] scsi: isci: phy: Mark expected switch fall-through
From
Date
Hi,

Friendly ping:

Who can ack or review this patch, please?

Thanks
--
Gustavo

On 11/27/18 10:29 PM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Addresses-Coverity-ID: 703127 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/scsi/isci/phy.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/isci/phy.c b/drivers/scsi/isci/phy.c
> index 1deca8c5a94f..7f9b3f20e5e4 100644
> --- a/drivers/scsi/isci/phy.c
> +++ b/drivers/scsi/isci/phy.c
> @@ -778,6 +778,7 @@ enum sci_status sci_phy_event_handler(struct isci_phy *iphy, u32 event_code)
> break;
> case SCU_EVENT_LINK_FAILURE:
> scu_link_layer_set_txcomsas_timeout(iphy, SCU_SAS_LINK_LAYER_TXCOMSAS_NEGTIME_DEFAULT);
> + /* fall through */
> case SCU_EVENT_HARD_RESET_RECEIVED:
> /* Start the oob/sn state machine over again */
> sci_change_state(&iphy->sm, SCI_PHY_STARTING);
>

\
 
 \ /
  Last update: 2018-12-19 23:27    [W:0.460 / U:30.664 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site