lkml.org 
[lkml]   [2018]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 3/6] irqchip: sifive-plic: More flexible plic_irq_toggle()
On Tue, Dec 18, 2018 at 02:20:10PM +0530, Anup Patel wrote:
> Actually these functions should not be inline because plic_toggle() uses
> raw_spin_lock() and plic_irq_toggle() uses for-loop.

So? It still inlines the all of two instances into each caller
for slightly different but related work. Not sure it is 100% worth
it, but probably more than the one to move the calculations to init
time..

\
 
 \ /
  Last update: 2018-12-19 17:29    [W:0.063 / U:3.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site