lkml.org 
[lkml]   [2018]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 13/41] scsi: csiostor: csio_wr: mark expected switch fall-through
From
Date
Hi,

Friendly ping:

Who can ack or review this patch, please?

Thanks
--
Gustavo

On 11/27/18 10:28 PM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Addresses-Coverity-ID: 1056538 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/scsi/csiostor/csio_wr.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/csiostor/csio_wr.c b/drivers/scsi/csiostor/csio_wr.c
> index dc12933533d5..b6861ea66c9f 100644
> --- a/drivers/scsi/csiostor/csio_wr.c
> +++ b/drivers/scsi/csiostor/csio_wr.c
> @@ -808,6 +808,7 @@ csio_wr_destroy_queues(struct csio_hw *hw, bool cmd)
>
> csio_q_eqid(hw, i) = CSIO_MAX_QID;
> }
> + /* fall through */
> case CSIO_INGRESS:
> if (csio_q_iqid(hw, i) != CSIO_MAX_QID) {
> csio_wr_cleanup_iq_ftr(hw, i);
>

\
 
 \ /
  Last update: 2018-12-19 16:40    [W:0.389 / U:16.648 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site