lkml.org 
[lkml]   [2018]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/9] staging: rtl8188eu: convert unsigned char arrays to u8
On Sat, Dec 15, 2018 at 05:46:11PM +0100, Michael Straube wrote:
> Covert unsigned char arrays to u8 and make them static and/or const
> where possible.

You are also moving things around here from different .h files in
different places. Always say exactly what you are doing.

And this too needs to be broken up into smaller pieces, don't make
things static/const when you change the type.

thanks,

greg k-h

\
 
 \ /
  Last update: 2018-12-17 14:51    [W:0.086 / U:31.556 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site