lkml.org 
[lkml]   [2018]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/11] staging: iio: adt7316: fix register and bit definitions
On Tue, 11 Dec 2018 17:54:53 -0700
Jeremy Fertic <jeremyfertic@gmail.com> wrote:

> Change two register addresses and one bit definition to match the
> datasheet.
>
> Signed-off-by: Jeremy Fertic <jeremyfertic@gmail.com>
One comment inline. I added a fixes tag but also a note saying I would
not suggest backporting to stable.

There are too many things wrong with this driver for any backports
to really be worthwhile. It didn't work at all for i2c until last cycle
for example!

Jonathan

> ---
> drivers/staging/iio/addac/adt7316.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
> index dc93e85808e0..1fa4a4c2b4f3 100644
> --- a/drivers/staging/iio/addac/adt7316.c
> +++ b/drivers/staging/iio/addac/adt7316.c
> @@ -59,8 +59,8 @@
> #define ADT7316_CONFIG1 0x18
> #define ADT7316_CONFIG2 0x19
> #define ADT7316_CONFIG3 0x1A
> -#define ADT7316_LDAC_CONFIG 0x1B
> -#define ADT7316_DAC_CONFIG 0x1C
> +#define ADT7316_DAC_CONFIG 0x1B
> +#define ADT7316_LDAC_CONFIG 0x1C
> #define ADT7316_INT_MASK1 0x1D
> #define ADT7316_INT_MASK2 0x1E
> #define ADT7316_IN_TEMP_OFFSET 0x1F
> @@ -117,7 +117,7 @@
> */
> #define ADT7316_ADCLK_22_5 0x1
> #define ADT7316_DA_HIGH_RESOLUTION 0x2
> -#define ADT7316_DA_EN_VIA_DAC_LDCA 0x4
> +#define ADT7316_DA_EN_VIA_DAC_LDCA 0x8
This looks to be called LDAC not LDCA?

Different error so I don't mind that being fixed later!

Jonathan
> #define ADT7516_AIN_IN_VREF 0x10
> #define ADT7316_EN_IN_TEMP_PROP_DACA 0x20
> #define ADT7316_EN_EX_TEMP_PROP_DACB 0x40

\
 
 \ /
  Last update: 2018-12-16 12:19    [W:0.135 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site