lkml.org 
[lkml]   [2018]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] usb: dwc3: gadget: fix miss isoc issue introduced by IRQ latency
Date
Hi Sergei:

>-----Original Message-----
>From: Sergei Shtylyov [mailto:sergei.shtylyov@cogentembedded.com]
>Sent: Friday, December 14, 2018 7:18 PM
>To: Zengtao (B) <prime.zeng@hisilicon.com>; balbi@kernel.org
>Cc: liangshengjun <liangshengjun@hisilicon.com>; Greg Kroah-Hartman
><gregkh@linuxfoundation.org>; linux-usb@vger.kernel.org;
>linux-kernel@vger.kernel.org
>Subject: Re: [PATCH] usb: dwc3: gadget: fix miss isoc issue introduced by
>IRQ latency
>
>Hello!
>
>On 12/14/2018 07:32 PM, Zeng Tao wrote:
>
>> If it's a busy system, some times when we start an isoc transfer, the
>> framenumber get from the event buffer may be already elasped, in this
>
> Frame number? Else my spell checker trips. :-)
>
>> case, we will get all the packets dropped due to miss isoc. And we
>> turn
>
> Remove the leading space, please.
>
>> into transfer nothing, to fix this issue, we need to fix the
>> framenumber to make sure that it's not out of date.
>>
>> Signed-off-by: Liang Shengjun <liangshengjun@hisilicon.com>
>> Signed-off-by: Zeng Tao <prime.zeng@hisilicon.com>
>[...]
>> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
>> index 9f92ee0..b63bd72 100644
>> --- a/drivers/usb/dwc3/gadget.c
>> +++ b/drivers/usb/dwc3/gadget.c
>> @@ -1263,6 +1263,15 @@ static int __dwc3_gadget_get_frame(struct
>dwc3 *dwc)
>> return DWC3_DSTS_SOFFN(reg);
>> }
>>
>> +static bool __dwc3_gadget_target_frame_elapsed(struct dwc3_ep
>*dep) {
>> + u16 cframe = __dwc3_gadget_get_frame(dep->dwc);
>> + u16 eframe = dep->frame_number &
>DWC3_EVENT_PRAM_SOFFN_MASK;
>> +
>> + return (((eframe - cframe) & DWC3_EVENT_PRAM_SOFFN_MASK)
>> + > DWC3_EVENT_PRAM_MAX_SOFFN / 2);
>
> Please leave > on the previous line.
> And you surely know that the outer parens are unnecessary? :-)
>

Thanks for your kindly corrections. :-), I will apply them in the patch if we need.

>[...]
>
>MBR, Sergei
\
 
 \ /
  Last update: 2018-12-17 02:55    [W:0.067 / U:0.820 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site