lkml.org 
[lkml]   [2018]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/9] staging: rtl8188eu: cleanup declarations in rtw_mlme_ext.c
From
Date
On 12/15/18 5:53 PM, Joe Perches wrote:
> On Sat, 2018-12-15 at 17:46 +0100, Michael Straube wrote:
>> Replace tabs with spaces and/or remove spaces in declarations.
>> Remove unused/commented declarations, remove unnecessary comment,
>> remove blank lines between declarations and add missing lines after
>> declarations. Also clears some line over 80 characters checkpatch
>> warnings.
> []
>> diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
> []
>> @@ -22,14 +22,14 @@ static u8 null_addr[ETH_ALEN] = {0, 0, 0, 0, 0, 0};
>> /**************************************************
>> OUI definitions for the vendor specific IE
>> ***************************************************/
>> -unsigned char RTW_WPA_OUI[] = {0x00, 0x50, 0xf2, 0x01};
>> +unsigned char RTW_WPA_OUI[] = {0x00, 0x50, 0xf2, 0x01};
>> unsigned char WMM_OUI[] = {0x00, 0x50, 0xf2, 0x02};
>> -unsigned char WPS_OUI[] = {0x00, 0x50, 0xf2, 0x04};
>> -unsigned char P2P_OUI[] = {0x50, 0x6F, 0x9A, 0x09};
>> -unsigned char WFD_OUI[] = {0x50, 0x6F, 0x9A, 0x0A};
>> +unsigned char WPS_OUI[] = {0x00, 0x50, 0xf2, 0x04};
>> +unsigned char P2P_OUI[] = {0x50, 0x6F, 0x9A, 0x09};
>> +unsigned char WFD_OUI[] = {0x50, 0x6F, 0x9A, 0x0A};
>>
>> -unsigned char WMM_INFO_OUI[] = {0x00, 0x50, 0xf2, 0x02, 0x00, 0x01};
>> -unsigned char WMM_PARA_OUI[] = {0x00, 0x50, 0xf2, 0x02, 0x01, 0x01};
>> +unsigned char WMM_INFO_OUI[] = {0x00, 0x50, 0xf2, 0x02, 0x00, 0x01};
>> +unsigned char WMM_PARA_OUI[] = {0x00, 0x50, 0xf2, 0x02, 0x01, 0x01};
>>
>> unsigned char WPA_TKIP_CIPHER[4] = {0x00, 0x50, 0xf2, 0x02};
>> unsigned char RSN_TKIP_CIPHER[4] = {0x00, 0x0f, 0xac, 0x02};
>
> unrelated trivia:
>
> Might be nice to make some or all of these const or
> even static const where appropriate.
>

Hi Joe,
I've done that in patch 4/9 of this series.

Michael

\
 
 \ /
  Last update: 2018-12-16 09:01    [W:0.090 / U:3.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site