lkml.org 
[lkml]   [2018]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 9/9] staging: rtl8188eu: cleanup brace coding style issues
    Date
    Cleanup brace coding style issues reported by checkpatch.

    ERROR: space required before the open brace '{'
    WARNING: braces {} are not necessary for single statement blocks
    CHECK: Unbalanced braces around else statement

    Signed-off-by: Michael Straube <straube.linux@gmail.com>
    ---
    drivers/staging/rtl8188eu/core/rtw_cmd.c | 3 +--
    drivers/staging/rtl8188eu/core/rtw_security.c | 4 ++--
    drivers/staging/rtl8188eu/hal/phy.c | 4 ++--
    drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c | 7 +++----
    drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 3 +--
    5 files changed, 9 insertions(+), 12 deletions(-)

    diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c b/drivers/staging/rtl8188eu/core/rtw_cmd.c
    index f9cdd1da8add..407f65cf7150 100644
    --- a/drivers/staging/rtl8188eu/core/rtw_cmd.c
    +++ b/drivers/staging/rtl8188eu/core/rtw_cmd.c
    @@ -214,9 +214,8 @@ int rtw_cmd_thread(void *context)
    pcmdpriv->cmdthd_running = false;

    /* free all cmd_obj resources */
    - while ((pcmd = rtw_dequeue_cmd(&pcmdpriv->cmd_queue))) {
    + while ((pcmd = rtw_dequeue_cmd(&pcmdpriv->cmd_queue)))
    rtw_free_cmd_obj(pcmd);
    - }

    complete(&pcmdpriv->terminate_cmdthread_comp);

    diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c b/drivers/staging/rtl8188eu/core/rtw_security.c
    index f7407632e80b..364d6ea14bf8 100644
    --- a/drivers/staging/rtl8188eu/core/rtw_security.c
    +++ b/drivers/staging/rtl8188eu/core/rtw_security.c
    @@ -1259,7 +1259,7 @@ u32 rtw_aes_encrypt(struct adapter *padapter, u8 *pxmitframe)
    length = pattrib->last_txcmdsz-pattrib->hdrlen-pattrib->iv_len-pattrib->icv_len;

    aes_cipher(prwskey, pattrib->hdrlen, pframe, length);
    - } else{
    + } else {
    length = pxmitpriv->frag_len-pattrib->hdrlen-pattrib->iv_len-pattrib->icv_len;

    aes_cipher(prwskey, pattrib->hdrlen, pframe, length);
    @@ -1267,7 +1267,7 @@ u32 rtw_aes_encrypt(struct adapter *padapter, u8 *pxmitframe)
    pframe = (u8 *)round_up((size_t)(pframe), 8);
    }
    }
    - } else{
    + } else {
    RT_TRACE(_module_rtl871x_security_c_, _drv_err_, ("%s: stainfo==NULL!!!\n", __func__));
    res = _FAIL;
    }
    diff --git a/drivers/staging/rtl8188eu/hal/phy.c b/drivers/staging/rtl8188eu/hal/phy.c
    index 051cfbab78b1..51c40abfafaa 100644
    --- a/drivers/staging/rtl8188eu/hal/phy.c
    +++ b/drivers/staging/rtl8188eu/hal/phy.c
    @@ -437,9 +437,9 @@ void rtl88eu_dm_txpower_tracking_callback_thermalmeter(struct adapter *adapt)
    thermal_val = (u8)(thermal_avg / thermal_avg_count);

    if (dm_odm->RFCalibrateInfo.bDoneTxpower &&
    - !dm_odm->RFCalibrateInfo.bReloadtxpowerindex)
    + !dm_odm->RFCalibrateInfo.bReloadtxpowerindex) {
    delta = abs(thermal_val - dm_odm->RFCalibrateInfo.ThermalValue);
    - else {
    + } else {
    delta = abs(thermal_val - hal_data->EEPROMThermalMeter);
    if (dm_odm->RFCalibrateInfo.bReloadtxpowerindex) {
    dm_odm->RFCalibrateInfo.bReloadtxpowerindex = false;
    diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c b/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
    index b832bbf202a5..7022221136f6 100644
    --- a/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
    +++ b/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
    @@ -90,15 +90,14 @@ static s32 FillH2CCmd_88E(struct adapter *adapt, u8 ElementID, u32 CmdLen, u8 *p

    /* Write Ext command */
    msgbox_ex_addr = REG_HMEBOX_EXT_0 + (h2c_box_num * RTL88E_EX_MESSAGE_BOX_SIZE);
    - for (cmd_idx = 0; cmd_idx < ext_cmd_len; cmd_idx++) {
    + for (cmd_idx = 0; cmd_idx < ext_cmd_len; cmd_idx++)
    usb_write8(adapt, msgbox_ex_addr+cmd_idx, *((u8 *)(&h2c_cmd_ex)+cmd_idx));
    - }
    }
    /* Write command */
    msgbox_addr = REG_HMEBOX_0 + (h2c_box_num * RTL88E_MESSAGE_BOX_SIZE);
    - for (cmd_idx = 0; cmd_idx < RTL88E_MESSAGE_BOX_SIZE; cmd_idx++) {
    + for (cmd_idx = 0; cmd_idx < RTL88E_MESSAGE_BOX_SIZE; cmd_idx++)
    usb_write8(adapt, msgbox_addr+cmd_idx, *((u8 *)(&h2c_cmd)+cmd_idx));
    - }
    +
    bcmd_down = true;

    adapt->HalData->LastHMEBoxNum =
    diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c
    index d5a1cf92ca6f..086f98d38cba 100644
    --- a/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c
    +++ b/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c
    @@ -232,9 +232,8 @@ s32 InitLLTTable(struct adapter *padapter, u8 txpktbuf_bndy)

    /* Let last entry point to the start entry of ring buffer */
    status = _LLTWrite(padapter, Last_Entry_Of_TxPktBuf, txpktbuf_bndy);
    - if (status != _SUCCESS) {
    + if (status != _SUCCESS)
    return status;
    - }
    }

    return status;
    --
    2.20.0
    \
     
     \ /
      Last update: 2018-12-15 17:47    [W:12.160 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site