lkml.org 
[lkml]   [2018]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v14 03/11] livepatch: Consolidate klp_free functions
On Thu, 13 Dec 2018, Josh Poimboeuf wrote:

> On Mon, Dec 03, 2018 at 03:59:57PM +0100, Miroslav Benes wrote:
> > On Thu, 29 Nov 2018, Petr Mladek wrote:
> >
> > > -static int klp_init_patch(struct klp_patch *patch)
> > > +/* Init operations that must succeed before klp_free_patch() can be called. */
> > > +static int klp_init_patch_before_free(struct klp_patch *patch)
> >
> > There is no klp_free_patch() now, so the comment is not correct. Also I
> > don't know if the function name is ideal, but I don't have a better one.
>
> Yeah, I found the name of this function to be confusing. It sounds like
> you're initializing the patch before freeing it, which seems like an
> obvious thing to do :-)
>
> How about klp_init_patch_early()?

That would work for me.

Miroslav

\
 
 \ /
  Last update: 2018-12-14 10:37    [W:0.065 / U:12.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site