lkml.org 
[lkml]   [2018]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 03/10] phy: Add MIPI D-PHY configuration options
On Thu, Dec 13, 2018 at 10:54:28PM +0200, sakari.ailus@iki.fi wrote:
> Hi Maxime,
>
> One more small note.
>
> On Fri, Dec 07, 2018 at 02:55:30PM +0100, Maxime Ripard wrote:
>
> ...
>
> > + /**
> > + * @wakeup:
> > + *
> > + * Time, in picoseconds, that a transmitter drives a Mark-1
> > + * state prior to a Stop state in order to initiate an exit
> > + * from ULPS.
> > + *
> > + * Minimum value: 1000000000 ps
> > + */
> > + unsigned int wakeup;
>
> This is very close to the higher limit of the type's value range. How about
> using ns or µs for this one?

Same for init actually.

--
Sakari Ailus

\
 
 \ /
  Last update: 2018-12-13 21:55    [W:0.085 / U:3.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site