lkml.org 
[lkml]   [2018]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/8] of: Drop full path from Sparc PDT full_name
From
From: Rob Herring <robh@kernel.org>
Date: Wed, 7 Nov 2018 16:31:45 -0600

> @@ -32,24 +32,7 @@ unsigned int of_pdt_unique_id __initdata;
>
> static char * __init of_pdt_build_full_name(struct device_node *dp)
> {
> - int len, ourlen, plen;
> - char *n;
> -
> - dp->path_component_name = build_path_component(dp);
> -
> - plen = strlen(dp->parent->full_name);
> - ourlen = strlen(dp->path_component_name);
> - len = ourlen + plen + 2;
> -
> - n = prom_early_alloc(len);
> - strcpy(n, dp->parent->full_name);
> - if (!of_node_is_root(dp->parent)) {
> - strcpy(n + plen, "/");
> - plen++;
> - }
> - strcpy(n + plen, dp->path_component_name);
> -
> - return n;
> + return build_path_component(dp);
> }
>
> #else /* CONFIG_SPARC */

Hmmm, shouldn't this be doing what the non-SPARC version of
of_pdt_build_full_name() does which is to return the component string
appended to the parent's full_name?

You're just returning the component string here.

\
 
 \ /
  Last update: 2018-11-09 04:12    [W:0.143 / U:3.904 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site