[lkml]   [2018]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 3/8] sparc: prom: use property "name" directly to construct node names
On Thu, Nov 8, 2018 at 9:13 PM David Miller <> wrote:
> From: Rob Herring <>
> Date: Wed, 7 Nov 2018 16:31:46 -0600
> > In preparation to remove direct accesses to the
> > pointer, retrieve the node name from the "name" property instead.
> >
> > Cc: "David S. Miller" <>
> > Cc:
> > Signed-off-by: Rob Herring <>
> On some 32-bit sparcs, the OF runs in non-cached memory.
> Sucking in the OF device tree take a signficant amount of the
> boot time on such systems.
> And these changes are going to make it even slower.
> Please just put a wrapper around dp->name or whatever and use that,
> instead of making more get property OF calls which can be very
> expensive.

It's not making calls into OF. It is retrieving the property from the
kernel's copy of the DT (allocated by memblock). So the only
difference is we have to walk the struct property list to find "name".
That's perhaps offset by the fact that we'll be doing one less
property retrieval from OF when this is all done. Right now, we
retrieve "name" from OF twice per node.


 \ /
  Last update: 2018-11-09 14:04    [W:0.155 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site