[lkml]   [2018]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 2/6] regulator: lochnagar: Move driver to binding from DT
On Thu, Nov 08, 2018 at 10:14:01AM +0000, Charles Keepax wrote:

> +static const struct of_device_id lochnagar_of_match[] = {
> + { .compatible = "cirrus,lochnagar-regulator" },
> + {},
> +};

This is obviously just dumping the Linux driver model into the DT, the
regulators are clearly different. If you want to explicitly list the
regulators in DT it'd be better to reflect the hardware and enumerate
the regulators individually - you can use one driver for all the MICVDDs
and a separate one for VDDCORE for example.
[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2018-11-08 13:17    [W:0.150 / U:1.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site