lkml.org 
[lkml]   [2018]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -next] iommu/amd: remove set but not used variable 'tag'
From
Date
On 2018/11/8 17:32, Joerg Roedel wrote:
> On Thu, Nov 08, 2018 at 06:12:40AM +0000, YueHaibing wrote:
>> - tag = event[1] & 0x03FF;
>> dev_err(dev, "INVALID_PPR_REQUEST device=%02x:%02x.%x pasid=0x%05x address=0x%016llx flags=0x%04x]\n",
>> PCI_BUS_NUM(devid), PCI_SLOT(devid), PCI_FUNC(devid),
>> pasid, address, flags);
>
> This looks like tag was just missed in the error message. It is better
> to add it there instead of removing it.

Ok, will post a new patch.

>
> Regards,
>
> Joerg
>
> .
>

\
 
 \ /
  Last update: 2018-11-08 12:13    [W:0.151 / U:4.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site