lkml.org 
[lkml]   [2018]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 4/5] mm, memory_hotplug: print reason for the offlining failure
On Wed 07-11-18 14:04:13, Andrew Morton wrote:
[...]
> Fix:
>
> --- a/mm/memory_hotplug.c~mm-memory_hotplug-print-reason-for-the-offlining-failure-fix
> +++ a/mm/memory_hotplug.c
> @@ -1576,7 +1576,7 @@ static int __ref __offline_pages(unsigne
> MIGRATE_MOVABLE, true);
> if (ret) {
> mem_hotplug_done();
> - reason = "failed to isolate range";
> + reason = "failure to isolate range";
> goto failed_removal
> }
>
> @@ -1587,7 +1587,7 @@ static int __ref __offline_pages(unsigne
> ret = memory_notify(MEM_GOING_OFFLINE, &arg);
> ret = notifier_to_errno(ret);
> if (ret) {
> - reason = "notifiers failure";
> + reason = "notifier failure";
> goto failed_removal_isolated;
> }
>
> @@ -1616,7 +1616,7 @@ repeat:
> */
> ret = dissolve_free_huge_pages(start_pfn, end_pfn);
> if (ret) {
> - reason = "fails to disolve hugetlb pages";
> + reason = "failure to dissolve huge pages";
> goto failed_removal_isolated;
> }
> /* check again */
> _
>

LGTM, thanks!

--
Michal Hocko
SUSE Labs

\
 
 \ /
  Last update: 2018-11-08 09:02    [W:0.069 / U:2.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site